Re: acpi: remove unused LIST_HEAD(acpi_device_list) && more static analysis

From: cheng renquan
Date: Tue Jul 10 2012 - 03:41:13 EST


On Tue, Jul 10, 2012 at 12:00 AM, cheng renquan <crquan@xxxxxxxxx> wrote:
> $ git diff HEAD -- drivers/acpi/scan.c
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 85cbfdc..7d26ae0 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -28,7 +28,7 @@ extern struct acpi_device *acpi_root;
>
> static const char *dummy_hid = "device";
>
> -static LIST_HEAD(acpi_device_list);
> static LIST_HEAD(acpi_bus_id_list);
> DEFINE_MUTEX(acpi_device_lock);
> LIST_HEAD(acpi_wakeup_device_list);

fortunately a later step of gcc optimization deleted that variable
so it doesn't consume space in the final vmlinux, only the really in-use
variable like the next acpi_bus_id_list consumed space;

$ eu-readelf -s drivers/acpi/scan.o |egrep '(acpi_device_list|acpi_bus_id_list)'
35: 00000000000000b0 16 OBJECT LOCAL DEFAULT 3 acpi_bus_id_list

$ eu-readelf -s vmlinux |egrep '(acpi_device_list|acpi_bus_id_list)'
24029: ffffffff81a62bc0 16 OBJECT LOCAL DEFAULT 15 acpi_bus_id_list


anyway, we'd better to delete the acpi_device_list from the source;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/