Re: [PATCH RFC 1/2] kvm vcpu: Note down pause loop exit

From: Raghavendra K T
Date: Tue Jul 10 2012 - 07:24:14 EST


On 07/10/2012 04:09 AM, Rik van Riel wrote:
On 07/09/2012 02:20 AM, Raghavendra K T wrote:

@@ -484,6 +484,13 @@ struct kvm_vcpu_arch {
u64 length;
u64 status;
} osvw;
+
+ /* Pause loop exit optimization */
+ struct {
+ bool pause_loop_exited;
+ bool dy_eligible;
+ } plo;

I know kvm_vcpu_arch is traditionally not a well documented
structure, but it would be really nice if each variable inside
this sub-structure could get some documentation.

Sure. Will document it.


Also, do we really want to introduce another acronym here?

Or would we be better off simply calling this struct .ple,
since that is a name people are already familiar with.

Yes. it makes sense to have .ple.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/