Re: [PATCH] rpmsg bus subsys_initcall initialization ordering

[Ohad Ben-Cohen]

Hi Federico,

On Tue, Jul 10, 2012 at 7:43 PM, Federico Fuga <fuga@xxxxxxxxxxxxxx> wrote:
> omaprpc is out of the official mainline code, it's inside the official ti/omap branch/project.

Ok, thanks for the explanation. In general, we don't change the
mainline kernel to solve issues with out-of-tree code.

> I guessed that the easier solution had been to change the initialization level, in a similar way it's done by the i2c bus driver for example.
> I don't know if this is the best solution to solve this, maybe the problem could be solved in the omaprpc driver (maybe this could be the right solution).
...
> Really, I don't have enough experience to say if it should be solved this way or not. For what I can see, this seems absolutely logic that busses are initialized before other drivers, so subsys_initcall should be perfectly logic.

I'm not convinced: there is no inherent reason for a bus and its
driver to live in separate initcalls, so this may all just be an
omaprpc issue.

> On the other hand, I didn't find another way to solve this dependency problem. I know there is also a Makefile approach, but the dependent driver (omaprpc) is in the staging driver directory, so I think is not feasible.
> Any other solution?

I'm not familiar with omaprpc, so I can't help much, sorry. The driver
doesn't seem to be in staging btw (or did you mean it lives in staging
in that out-of-tree repository?).

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/