Re: [PATCH 1/4] [SCSI] ufs: Separate PCI glue driver for ufshcd

[vinayak holikatti]

On Mon, Jul 2, 2012 at 8:47 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Monday 02 July 2012, Vinayak Holikatti wrote:
>>
>> This patch separates PCI and core UFS host controller driver.
>> In the current implementation PCI specific code is with ufshcd.c.
>> To provide way for adding multiple bus glue driver, this patch
>> separates PCI layer from ufshcd core. Now ufshcd compiles as separate
>> module and ufshcd-pci as separate module.
>>
>> Signed-off-by: Vinayak Holikatti <vinholikatti@xxxxxxxxx>
>> Signed-off-by: Santosh Yaraganavi <santoshsy@xxxxxxxxx>
>
> Hi Vinayak,
>
> This patch looks good at first sight, but it's a little hard to
> review in the form that you are posting.
>
> I would recommend that you split this patch into two separate
> changesets, where you do all the changes to existing code in the
> first patch, and only move but don't change code in the second one
> that creates the new file.
 Ok, will spilt accordinglly to make it two changesets.
>
>         Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/