Re: [PATCH] mm/slob: avoid type warning about alignment value

From: Arnd Bergmann
Date: Wed Jul 11 2012 - 02:39:51 EST


On Wednesday 11 July 2012, David Rientjes wrote:
> Wouldn't it be better to avoid this problem more generally by casting the
> __alignof__ for ARCH_{KMALLOC,SLAB}_MINALIGN to int in slab.h? All
> architectures that define these themselves will be using plain integers,
> the problem is __alignof__ returning size_t when undefined.

I thought about it but I wasn't sure if that would cover all possible
cases. My version at least is known not to introduce a different type
mismatch on another architecture.

Also, size_t seems to be the correct type here, while the untyped
definition is just an int.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/