RE: [PATCH V3 3/7] mfd: samsung: Modify samsung mfd header

[Venu Byravarasu]

> --- /dev/null
> +++ b/include/linux/mfd/samsung/core.h
> @@ -0,0 +1,147 @@
> +/*
> + * core.h
> + *
> + * copyright (c) 2011 Samsung Electronics Co., Ltd
> + *              http://www.samsung.com

In most of the files you mentioned 2011.
Should they not be changed to 2012?

> + *
> + *  This program is free software; you can redistribute  it and/or modify it
> + *  under  the terms of  the GNU General  Public License as published by the
> + *  Free Software Foundation;  either version 2 of the  License, or (at your
> + *  option) any later version.




> -
> -#ifndef __LINUX_MFD_S5M_CORE_H
> -#define __LINUX_MFD_S5M_CORE_H
> -
> -
> -	int				buck_set1;
> -	int				buck_set2;
> -	int				buck_set3;

As you have buck4_enable etc below, by any chance do you need buck_set4 as well here?
Similarly should you declare buck1_enable here?

> -	int				buck2_enable;
> -	int				buck3_enable;
> -	int				buck4_enable;
> -	int				buck_default_idx;
> -	int				buck2_default_idx;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/