Re: [PATCH RFC 0/2] kvm: Improving directed yield in PLE handler

From: Raghavendra K T
Date: Wed Jul 11 2012 - 09:06:35 EST


On 07/11/2012 05:21 PM, Raghavendra K T wrote:
On 07/11/2012 03:47 PM, Christian Borntraeger wrote:
On 11/07/12 11:06, Avi Kivity wrote:
[...]
So there is no win here, but there are other cases were diag44 is
used, e.g. cpu_relax.
I have to double check with others, if these cases are critical, but
for now, it seems
that your dummy implementation for s390 is just fine. After all it
is a no-op until
we implement something.

Does the data structure make sense for you? If so we can move it to
common code (and manage it in kvm_vcpu_on_spin()). We can guard it with
CONFIG_KVM_HAVE_CPU_RELAX_INTERCEPT or something, so other archs don't
have to pay anything.

Ignoring the name, yes the data structure itself seems based on the
algorithm
and not on arch specific things. That should work.

Ok. can you please elaborate, on the flow.


Ok got it.. Will check how the code can be common to both x86 and s390.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/