Re: [PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

[Hans Verkuil]

On Wed 11 July 2012 16:19:02 Federico Vaga wrote:
> > > > @@ -445,9 +402,9 @@ static const struct v4l2_subdev_video_ops
> > > > adv7180_video_ops = {> 
> > > >  static const struct v4l2_subdev_core_ops adv7180_core_ops = {
> > > >  
> > > >   .g_chip_ident = adv7180_g_chip_ident,
> > > >   .s_std = adv7180_s_std,
> > > > 
> > > > - .queryctrl = adv7180_queryctrl,
> > > > - .g_ctrl = adv7180_g_ctrl,
> > > > - .s_ctrl = adv7180_s_ctrl,
> > > > + .queryctrl = v4l2_subdev_queryctrl,
> > > > + .g_ctrl = v4l2_subdev_g_ctrl,
> > > > + .s_ctrl = v4l2_subdev_s_ctrl,
> > > 
> > > I'm not sure to undestand this point. I "grepped" for the adv7180
> > > and it seem that I'm the only user of the adv7180 (sta2x11 VIP
> > > driver). In the VIP driver I don't use the control framework (there
> > > aren't controls), so I think these lines must be there. Am I wrong?
> > 
> > Correct. But once sta2x11 is converted to using the control framework,
> > then these lines can be dropped since no one else is using this
> > subdevice driver.
> 
> What do you suggest? I re-submit this patch and when sta2x11 is fixed a 
> I submit a new patch to remove these lines; or wait the full conversion 
> of the sta2x11 driver and submit both patch?

Choice 1: when sta2x11 is fixed submit a new patch to remove those lines.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/