Re: [PATCH RFC 1/2] kvm vcpu: Note down pause loop exit

From: Nikunj A Dadhania
Date: Thu Jul 12 2012 - 06:59:27 EST


On Wed, 11 Jul 2012 16:22:29 +0530, Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx> wrote:
> On 07/11/2012 02:23 PM, Avi Kivity wrote:
> >
> > This adds some tiny overhead to vcpu entry. You could remove it by
> > using the vcpu->requests mechanism to clear the flag, since
> > vcpu->requests is already checked on every entry.
>
> So IIUC, let's have request bit for indicating PLE,
>
> pause_interception() /handle_pause()
> {
> make_request(PLE_REQUEST)
> vcpu_on_spin()
>
> }
>
> check_eligibility()
> {
> !test_request(PLE_REQUEST) || ( test_request(PLE_REQUEST) &&
> dy_eligible())
> .
> .
> }
>
> vcpu_run()
> {
>
> check_request(PLE_REQUEST)
>
I know check_request will clear PLE_REQUEST, but you just need a
clear_request here, right?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/