Re: [PATCHv3 0/4] hfsplus: stop using write_supers and s_dirt

From: Andrew Morton
Date: Thu Jul 12 2012 - 19:17:10 EST


On Thu, 12 Jul 2012 16:09:51 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > 2. removed 'cancel_delayed_work()' from 'hfsplus_sync_fs()' because it is not
> > enough to just cancel the job, we need to set the work_queued flag to zero
> > as well. I could do this, but it is simpler to just remove this tiny
> > optimization - we do not gain much with it. I caught this bug while doing
> > some more testing.
>
> And lo, when I look at "what was changed", I see that this patchset
> actually does *not* remove the cancel_delayed_work() call. What's up
> with that?

Ah, no. I was looking at the cancel_delayed_work() in hfs_put_super().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/