Re: Remove easily user-triggerable BUG from generic_setlease

From: Dave Jones
Date: Fri Jul 13 2012 - 13:50:31 EST


On Fri, Jul 13, 2012 at 10:47:43AM -0700, Linus Torvalds wrote:
> On Fri, Jul 13, 2012 at 10:35 AM, Dave Jones <davej@xxxxxxxxxx> wrote:
> > This can be trivially triggered from userspace by passing in something unexpected.
>
> Argh. It looks like it would be harmless (apart from the noise),
> except we hold file_lock_lock. Which turns the BUG_ON() into not just
> "noise and kill the process", but "noise and kill the process and
> leave a nasty lock held".

Yeah, box wedged shortly afterwards. Not cool.

> This seems to go back to 3.2, so stable should be cc'd, no?

yeah, definitly. my bad.

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/