Re: [PATCH] bnx2: update bnx2-mips-09 firmware tobnx2-mips-09-6.2.1b

From: Ben Hutchings
Date: Sat Jul 14 2012 - 00:28:00 EST


On Fri, 2012-07-13 at 15:09 +0100, Chris Webb wrote:
> Eric Dumazet <eric.dumazet@xxxxxxxxx> writes:
>
> > Have you read firmware/README.AddingFirmware ?
>
> I hadn't, but now I have, and if firmware upgrades are considered 'adding
> new firmware', I agree this patch is wrong, and should have just removed the
> obsolete bnx2-mips-09-6.2.1a file that is no longer used by the bnx2 driver.
>
> However, not having dealt with cards that need these kinds of horrible
> binary blobs before, I'm a little uncertain how I should be building
> upstream kernels with CONFIG_FIRMWARE_IN_KERNEL and pulling in the correct
> blobs from a linux-firmware checkout.
>
> Is there a more automatic method than going through the source for each
> configured driver and setting CONFIG_EXTRA_FIRMWARE manually to list the
> relevant firmwares? Is there any way to give the kernel the location of
> linux-firmware and have it compile in everything needed for the selected
> drivers, as used to happen with the firmware/ subdirectory?
> CONFIG_EXTRA_FIRMWARE_DIR doesn't seem to do anything with
> CONFIG_EXTRA_FIRMWARE empty, so I don't think it does what I'm hoping?

I had a go at making CONFIG_FIRMWARE_IN_KERNEL pick the right blobs
automatically <http://thread.gmane.org/gmane.linux.kernel/1230462>, but
I couldn't get the Kbuild rules quite right. No-one responded and I
haven't had another try since.

Ben.

--
Ben Hutchings
The generation of random numbers is too important to be left to chance.
- Robert Coveyou

Attachment: signature.asc
Description: This is a digitally signed message part