Re: [PATCH] Checkpatch fixes for drivers/staging/panel/panel.c

From: richard -rw- weinberger
Date: Sun Jul 15 2012 - 11:35:58 EST


On Sun, Jul 15, 2012 at 2:44 PM, Cruz Julian Bishop
<cruz@xxxxxxxxxxxxxxxxxxxx> wrote:
> #if 0
> - printk(KERN_DEBUG
> - "entering panel_process_inputs with pp=%016Lx & pc=%016Lx\n",
> + pr_debug("entering panel_process_inputs with pp=%016Lx & pc=%016Lx\n",
> phys_prev, phys_curr);
> #endif

Instead of following checkpatch.pl's suggestions in a completely
brain-dead manner you should better read the code.
The printk() is under a "#if 0", so the whole block is useless anyway...

--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/