Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN

[Daniel Mack]

On 17.07.2012 14:59, Daniel Mack wrote:
> On 13.07.2012 09:01, Dmitry Torokhov wrote:
>> On Wed, May 02, 2012 at 09:36:51PM -0700, Dmitry Torokhov wrote:
>>> Hi Sven,
>>>
>>> On Sat, Apr 07, 2012 at 08:38:33PM +0200, Sven Neumann wrote:
>>>> Hi,
>>>>
>>>> On 07.04.12 09:02, Dmitry Torokhov wrote:
>>>>> On Fri, Apr 06, 2012 at 10:40:07PM -0700, Olof Johansson wrote:
>>>>>> This seems to have been broken since 2010, so obviously noone actually
>>>>>> cares about the driver:
>>>>>>
>>>>>> make[4]: *** [drivers/input/touchscreen/eeti_ts.o] Error 1
>>>>>> drivers/input/touchscreen/eeti_ts.c: In function 'eeti_ts_irq_active':
>>>>>> drivers/input/touchscreen/eeti_ts.c:65:2: error: implicit declaration of function 'irq_to_gpio' [-Werror=implicit-function-declaration]
>>>>>>
>>>>>> irq_to_gpio isn't available on most platforms today, so the driver
>>>>>> will need some rework by someone who has hardware access and can test
>>>>>> (to make sure that, for example, switching to level interrupts and just
>>>>>> keep taking them while there's more to process works).
>>>>>>
>>>>>> I guess it could just be scheduled for removal, but let's start with
>>>>>> marking it CONFIG_BROKEN.
>>>>>
>>>>> Well, it probably works quite well on arches that do have irq_to_gpio(),
>>>>> let's ask Daniel and Sven if they still have this hardware and if they
>>>>> can try the patch below that implements what you suggested.
>>>>
>>>> This hardware is still in use and we also still follow kernel
>>>> development and try to update our customer devices to recent kernel
>>>> versions regularly. Currently we are at 3.1.10 and the touchscreen
>>>> works well with that. I'll try to update to a more recent kernel
>>>> next week and will try your patch.
>>>>
>>>
>>> Did you have a chance to test the patch?
>>
>> *ping*
>>
>> It would be nice to get driver in mainline compile [and work] again...
> 
> We gave that patch a quick try today and it doesn't seem to work. We
> don't get any events from the touch screen anymore. We need to debug
> this further, hopefully by the end of this week.
> 
> If there's anything obvious in the setup of the threaded IRQ handler,
> please let us know. Otherwise, I'll get back once I have a fixed version
> of the patch.

Ok, finally I found some time. In general, the patch works fine. The
only detail I had to amend was the irqflags, which were changed from
IRQF_TRIGGER_RISING/IRQF_TRIGGER_FALLING to
IRQF_TRIGGER_HIGH/IRQF_TRIGGER_LOW, which doesn't work as the PXA can't
deal with level-based IRQs. Changing this back to RISING/FALLING makes
the driver work again.

With that correction, feel free to add my Acked-by:/Tested-by:

Thanks and sorry again for the slow response.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/