Re: [RFC][PATCH] hwmon: add support for Sensirion C1 sensor

From: Johannes Winkelmann
Date: Fri Jul 20 2012 - 11:35:27 EST


On Fri, Jul 20, 2012 at 5:14 PM, Oliver Neukum <oneukum@xxxxxxx> wrote:
> On Friday 20 July 2012 17:13:51 Johannes Winkelmann wrote:
>> On Fri, Jul 20, 2012 at 4:03 PM, Oliver Neukum <oneukum@xxxxxxx> wrote:
>
>> > We have dedicated macros for conversion of endianness.
>>
>> Like this:
>> val = swab16p((__le16 *)buf);
>> data->temperature = ((21875 * val) >> 13) - 45000;
>> val = swab16p((__le16 *)(buf+2));
>> data->humidity = ((15000 * val) >> 13) - 10000;
>
> I was thinking of be16_to_cpu()

Ok, fixed locally; I'll collect some more feedback and will resubmit v2

Thanks,
Johannes
--
Johannes Winkelmann
jw@xxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/