Re: [PATCH v2] posix_types.h: make __NFDBITS compatible with glibcdefinition

[Jeff Law]

On 07/24/12 13:24, Linus Torvalds wrote:
> On Tue, Jul 24, 2012 at 12:15 PM, Jeff Law <law@xxxxxxxxxx> wrote:
> > Please refer to the original discussion where they did evaluate the cost of
> > this change and tested that the final change made no difference to the
> > generated code.
>
> Umm. That bugzilla entry seems to be talking about a *sane* change, namely
>
> -  ({ unsigned long int __d = (d);					    \
> +  ({ unsigned long int __d = (unsigned long int) (d);			    \
>
> in __FD_ELT(), which is totally different from the one Josh talks about.
Right.  Josh's change is necessary to prevent warnings from folks 
(incorrectly) using posix_types.h instead of select.h after the change 
in that BZ was made.  That's why I originally stated that, arguably, 
posix_types.h really should go away or just use the definitions provided 
by glibc.


Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/