Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant

[John David Anglin]

On 24-Jul-12, at 3:48 AM, Fengguang Wu wrote:

> Here is the line in sock.i:
>
> struct static_key memalloc_socks = ((struct static_key) { .enabled =  
> ((atomic_t) { (0) }) });


The above line contains two compound literals.  It also uses a  
designated initializer
to initialize the field enabled.  A compound literal is not a constant  
expression.

The location of the above statement isn't fully clear, but if a  
compound literal occurs
outside the body of a function, the initializer list must consist of  
constant expressions.

Removing "(atomic_t)" from the define results in a constant expression.

Test case:

typedef struct { long enabled; } atomic_t;
struct static_key { atomic_t enabled; int x; };
struct static_key memalloc_socks = ((struct static_key) { .enabled =  
((atomic_t) { (0) }) });

Dave
--
John David Anglin	dave.anglin@xxxxxxxx



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/