Re: [PATCH 14/17] perf, tool: Support for dwarf cfi unwinding onpost processing

[Frederic Weisbecker]

On Wed, Jul 25, 2012 at 02:16:55PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 25, 2012 at 07:05:33PM +0200, Frederic Weisbecker escreveu:
> > > +#ifdef ARCH_X86_64
> > > +int unwind__arch_reg_id(int regnum)
> > 
> > Please try to avoid __ in function names. We used that convention
> > before but we gave up because that's actually more painful than
> > anything.
> 
> Well, I continue using it to separate the struct operated by the
> function from the function name.

As you prefer. I personally don't like it much because when I grep
for some function I have in mind, I stick on finding the right
underscore layout :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/