Re: [PATCH] x86/ioapic: Fix NULL pointer dereference on CPU hotplugafter disabling irqs

From: Tomoki Sekiyama
Date: Thu Jul 26 2012 - 05:38:34 EST


Hi, thanks for your comment.

On 2012/07/26 8:28, Siddha, Suresh B wrote:
> Tomoki wrote:
>> In current Linux, percpu variable `vector_irq' is not always cleared when
>> a CPU is offlined. If the cpu that has the disabled irqs in vector_irq is
>> hotplugged again, __setup_vector_irq() hits invalid irq vector and may
>> crash.
>>
>> Commit f6175f5bfb4c partially fixes this, but was not enough in
>> environments with IOMMU IRQ remapper.
>
> So, this patch essentially makes the commit f6175f5bfb4c unnecessary, right?
>
> Can you revert that too as part of this new proposed patch?
>
> thanks,
> suresh

OK, I will include a reverse patch of f6175f5bfb4c and resend the patch.

Thanks,
--
Tomoki Sekiyama <tomoki.sekiyama.qu@xxxxxxxxxxx>
Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/