Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

From: Peter Chubb
Date: Thu Jul 26 2012 - 18:46:44 EST


>>>>> "Ingo" == Ingo Molnar <mingo@xxxxxxxxxx> writes:

Ingo> * James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
>> Since the problem is an invalid assumption about how the stack
>> grows, why not just condition it on that. We actually have a
>> config option for this: CONFIG_STACK_GROWSUP. But for some reason
>> ia64 doesn't define this, why not, Tony? It looks deliberate
>> because you have replaced a lot of
>>
>> #ifdef CONFIG_STACK_GROWSUP
>>
>> with
>>
>> #if defined(CONFIG_STACK_GROWSUP) || defined(CONFIG_IA64)
>>
>> but not all of them.

Ingo> Yes, that's another possible solution, assuming that it's really
Ingo> only about the up/down difference.

Ingo> Thanks,

IA64 has two stacks -- the standard one, that grows down, and the
register stack engine backing store, that grows up. The usual
mechanisms for stack growth are used, so only some of the bits
predicated on `STACK_GROWSUP' are useful.

Peter C
--
Dr Peter Chubb peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/