Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

[Alan Cox]

> +enum {
> +	VMCI_SUCCESS_QUEUEPAIR_ATTACH	=  5,
> +	VMCI_SUCCESS_QUEUEPAIR_CREATE	=  4,
> +	VMCI_SUCCESS_LAST_DETACH	=  3,
> +	VMCI_SUCCESS_ACCESS_GRANTED	=  2,
> +	VMCI_SUCCESS_ENTRY_DEAD	=  1,

We've got a nice collection of Linux error codes than you, and it would
make the driver enormously more readable on the Linux side if as low
level as possible it started using Linux error codes.


> +	VMCI_SUCCESS			=  0,
> +	VMCI_ERROR_INVALID_RESOURCE	= (-1),
> +	VMCI_ERROR_INVALID_ARGS	= (-2),
> +	VMCI_ERROR_NO_MEM		= (-3),
> +	VMCI_ERROR_DATAGRAM_FAILED	= (-4),
> +	VMCI_ERROR_MORE_DATA		= (-5),
> +	VMCI_ERROR_NO_MORE_DATAGRAMS	= (-6),
> +	VMCI_ERROR_NO_ACCESS		= (-7),
> +	VMCI_ERROR_NO_HANDLE		= (-8),
> +	VMCI_ERROR_DUPLICATE_ENTRY	= (-9),
> +	VMCI_ERROR_DST_UNREACHABLE	= (-10),
> +	VMCI_ERROR_PAYLOAD_TOO_LARGE	= (-11),
> +	VMCI_ERROR_INVALID_PRIV	= (-12),
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/