Re: [PATCH] staging:net:fixed to fit tty_driver's kref field

From: Sam Ravnborg
Date: Sun Jul 29 2012 - 15:40:41 EST


On Sun, Jul 29, 2012 at 10:06:32PM +0800, Baodong Chen wrote:
> Fixed code to fix tty_driver's kref field
> Coding style issues
>
> Signed-off-by: Baodong Chen <chenbdchenbd@xxxxxxxxx>

Hi Baodong.

As already pointed out by Jiri please split this
up in several patches.

[PATCH 1/x] staging:net:pc300: fix white space usage
[PATCH 2/x] staging:net:pc300: add proper kref support
[PATCH 3/x] staging:net:pc300: use pr_dev
[PATCH 4/x] staging:net:pc300: drop use of CPC_TTY_LOCK/CPC_TTY_UNLOCK macros
etc...

The latter two is not impleted yet but proposals for further cleanups.

Sam

> ---
> drivers/staging/net/pc300_tty.c | 123 ++++++++++++++++++++------------------
> 1 files changed, 65 insertions(+), 58 deletions(-)
>
> diff --git a/drivers/staging/net/pc300_tty.c b/drivers/staging/net/pc300_tty.c
> index 4709f42..8a7277c 100644
> --- a/drivers/staging/net/pc300_tty.c
> +++ b/drivers/staging/net/pc300_tty.c

>
> - cpc_tty = (st_cpc_tty_area *) tty->driver_data;
> + cpc_tty = (st_cpc_tty_area *) tty->driver_data;
^drop space

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/