Re: [PATCH] x86: don't ever patch back to UP if we unplug cpus.

From: Rusty Russell
Date: Sun Jul 29 2012 - 22:14:13 EST


On Fri, 27 Jul 2012 13:28:29 -0700, Suresh Siddha <suresh.b.siddha@xxxxxxxxx> wrote:
> if (!noreplace_smp && (num_present_cpus() == 1 || setup_max_cpus <= 1))
>
> also, to be consistent with other checks, may be just use
> "num_possible_cpus() == 1" check instead of "setup_max_cpus <= 1".

Actually, if you specify "maxcpus=1" on the kernel command line,
you get num_possible_cpus() == 4, even though only one gets online.

So the setup_max_cpus check is in fact correct here.

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/