Re: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create()

From: Pekka Enberg
Date: Mon Jul 30 2012 - 16:41:39 EST


On Mon, Jul 30, 2012 at 10:56 PM, David Rientjes <rientjes@xxxxxxxxxx> wrote:
> -Wunused-label is overridden in gcc for a label that is conditionally
> referenced by using __maybe_unused in the kernel. I'm not sure what's so
> obscure about
>
> out: __maybe_unused
>
> Are label attributes really that obsecure?

I think they are.

The real problem, however, is that label attributes would just paper
over the badly thought out control flow in the function and not make the
code any better or easier to read.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/