Re: [PATCH 0/3] x86, MSI: Support multiple MSIs in presense of IRQremapping

From: Suresh Siddha
Date: Tue Jul 31 2012 - 17:16:16 EST


On Tue, 2012-07-31 at 13:41 +0200, Alexander Gordeev wrote:
> Currently multiple MSI mode is limited to a single vector per device (at
> least on x86 and PPC). This series breathes life into pci_enable_msi_block()
> and makes it possible to set interrupt affinity for multiple IRQs, similarly
> to MSI-X. Yet, only for x86 and only when IOMMUs are present.
>
> Although IRQ and PCI subsystems are modified, the current behaviour left
> intact. The drivers could just start using multiple MSIs just by following
> the existing documentation.

So while I am ok with the proposed changes, I will hold off acking until
I see the corresponding driver changes (using pci_enable_msi_block()
etc) that take advantage of these changes ;)

Did you have a specific device in mind and are the driver changes
coming?

thanks,
suresh

>
> The patches are adapted to Ingo's -tip repository, x86/apic branch.
>
> Alexander Gordeev (3):
> x86, MSI: Support multiple MSIs in presense of IRQ remapping
> x86, MSI: Allocate as many multiple IRQs as requested
> x86, MSI: Minor readability fixes
>
> arch/x86/kernel/apic/io_apic.c | 170 +++++++++++++++++++++++++++++++++++++---
> drivers/pci/msi.c | 10 ++-
> include/linux/irq.h | 6 ++
> include/linux/msi.h | 1 +
> kernel/irq/chip.c | 30 +++++--
> kernel/irq/irqdesc.c | 31 +++++++
> 6 files changed, 226 insertions(+), 22 deletions(-)
>
> --
> 1.7.7.6
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/