Re: [PATCH] module: Fix compile error for ref_module whenCONFIG_MODULES is not set

[Barbaros TokaoÄlu]

Hi Rusty,

You are right, this was not for something in the kernel. I needed
ref_module to add some sort of dynamic dependency between modules but
this caused compile error when CONFIG_MODULES is not set. Another
option was using #ifdef CONFIG_MODULES check but the way in the patch
seemed correct to me.

However, if ref_module is exported only for ksplice, then you can
ignore this patch.

Thanks,
Barbaros

On Aug 6, 2012, at 9:58 AM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> On Wed, 1 Aug 2012 20:57:07 +0300, Barbaros TokaoÄlu <barbarost@xxxxxxxxx> wrote:
>> ref_module function is not defined when CONFIG_MODULES is not set thus
>> it causes compile error when a module which is set to be built-in uses it.
>> This patch defines a dummy ref_module function when CONFIG_MODULES
>> is not set.
>>
>> Signed-off-by: Barbaros TokaoÄlu <barbarost@xxxxxxxxx>
>
> Hi Barbaros,
>
>       It's usually a good idea to paste the error message into the
> commit message for compile fixes: it helps people googling the problem.
>
> In this case, it's particularly important, because I can't find any
> users of ref_module() outside module.c itself: it's only exported for
> ksplice to use.
>
> Cheers,
> Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/