Re: [PATCH] ARM: SAMSUNG: Fix compilation error withs3c2410_defconfig

[Thierry Reding]

On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote:
> Thierry Reding wrote:
> > 
> > On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote:
> > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-
> > samsung/Kconfig
> > > index 7aca31c..dcdfb77 100644
> > > --- a/arch/arm/plat-samsung/Kconfig
> > > +++ b/arch/arm/plat-samsung/Kconfig
> > > @@ -403,7 +403,7 @@ config S5P_DEV_USB_EHCI
> > >
> > >  config S3C24XX_PWM
> > >  	bool "PWM device support"
> > > -	select HAVE_PWM
> > > +	select PWM
> > >  	help
> > >  	  Support for exporting the PWM timer blocks via the pwm device
> > >  	  system
> > 
> > You could add
> > 
> > 	select PWM_SAMSUNG
> > 
> Well, the 'PWM_SAMSUNG' depends on 'PWM', so I think, it'd better to select
> PWM_SAMSUNG for building pwm-samsung.c automatically when PWM is selected.
> 
> > here to side-step the issue below.
> > 
> > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> > > index 8fc3808..34c8ec1 100644
> > > --- a/drivers/pwm/Kconfig
> > > +++ b/drivers/pwm/Kconfig
> > > @@ -59,7 +59,7 @@ config PWM_PXA
> > >
> > >  config PWM_SAMSUNG
> > >  	tristate "Samsung pwm support"
> > > -	depends on PLAT_SAMSUNG
> > > +	def_bool PLAT_SAMSUNG
> > 
> > tristate and def_bool conflict, don't they? I think the easiest way to
> 
> Yeah, your pointing out is correct, but in this case, it should be 'bool'
> not 'tristate' because the PWM driver cannot support module now.

Is there any reason why that is so? Looking at the driver it seems like
it should be easy to turn it into a module. I know that Jingoo (Cc'ed)
has been working on the driver and I've asked him the same question
already.

Anyway I don't want to force the issue, I just think you should consider
it.

> > solve this problem would be to add a default line, like so:
> > 
> > 	default PLAT_SAMSUNG
> > 
> > I've checked this with a s3c2410_defconfig and this causes PWM_SAMSUNG
> > to be selected =y, which I guess is what you want.
> > 
> How do you think following, just adding from original one?
> 
> -	tristate "Samsung pwm support"
> +	bool "SAMSUNG PWM support"
> 
> Thanks.

If you convert this to bool anyway, then maybe you can still use
def_bool:

	config PWM_SAMSUNG
		prompt "SAMSUNG PWM support" if PLAT_SAMSUNG
		def_bool PLAT_SAMSUNG

Any particular reason why you want "SAMSUNG" capitalized?

Thierry

Attachment: pgp00000.pgp
Description: PGP signature