Re: [PATCH] pinctrl/nomadik: add ASIC DB8450 pinctrl driver

[Linus Walleij]

On Tue, Aug 7, 2012 at 10:26 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:

>> @@ -1722,6 +1722,8 @@ static int __devinit nmk_pinctrl_probe(struct platform_device *pdev)
>>       /* Poke in other ASIC variants here */
>>       if (version == PINCTRL_NMK_DB8500)
>>               nmk_pinctrl_db8500_init(&npct->soc);
>> +     if (platid->driver_data == PINCTRL_NMK_DB8540)
>> +             nmk_pinctrl_db8540_init(&npct->soc);
>
> I'm surprised one of those checks "version" and the other
> "platid->driver_data".
>
> Aside from that, this looks fine.

Bah, I'll fix this, then add your ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/