RE: [PATCH] net: add new QCA alx ethernet driver

[Ren, Cloud]

Hi Jeo
I only want to do some additional explanations to david. It makes nothing with original patch.
Thanks
cloud

-----Original Message-----
From: Joe Perches [mailto:joe@xxxxxxxxxxx] 
Sent: 2012å8æ9æ 12:10
To: Ren, Cloud
Cc: davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; qca-linux-team; nic-devel; Huang, Xiong; Hao-Ran Liu(Joseph Liu); Rodriguez, Luis
Subject: RE: [PATCH] net: add new QCA alx ethernet driver

On Thu, 2012-08-09 at 02:27 +0000, Ren, Cloud wrote:
> Hi David,
[]
> The alx driver only supports two new nics(l1f/l2f) now.  It doesn't supersede atl1c driver.
> Atl1c driver still supports old nics.
[]
> -----Original Message-----
> From: Ren, Cloud
> Sent: 2012å8æ9æ 18:15
[]
> This driver support two new ethernet chipsets:

[+400kb of entire original patch]

Did you really have to quote 400kb of original patch to make that prefixing statement to David?

[]


> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
 
I would prefer my name not be listed as a Signed-off-by.

I don't have a card, I never tested it, etc.  What I did do is a light review and made a couple of trivial patch suggestions about how you might make logging code a bit smaller.

Thanks and cheers, Joe

N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i