Re: [PATCH 1/3] perf tools: Initial bash completion support

From: Frederic Weisbecker
Date: Fri Aug 10 2012 - 09:30:09 EST


On Thu, Aug 09, 2012 at 04:08:19PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 09, 2012 at 07:27:06PM +0100, Alan Cox escreveu:
> > > > 3rd patch should fix this.
> > >
> > > Huh? The problem is not /etc/bash_completion.d/ not existing, it exists,
> > > its just that I'm not using sudo nor installing as root, this new bash
> > > completion file is the only one that is being installed on the root
> > > filesystem, all others are in ~acme/
> >
> > And even with permissions it might not have the right security labels on
> > a well secured box.
> >
> > It's a neat little script (or once its been properly security audited
> > will be) but IMHO it belongs in the distro bash script packages.
>
> Yeah, I think we can keep it in the kernel sources and then send new
> versions to the bash-completion-devel@xxxxxxxxxxxxxxxxxxxxxxx guys.
>
> To test I just did:
>
> ln -s ~/etc/bash_completion.d/perf ~/.bash_completion
>
> Frédéric, I merged your patches as-is and pushed them to my perf/core
> branch, thanks!

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/