Re: [PATCH 1/6] ARM: dove: unify clock setup
From: Andrew Lunn
Date: Sat Aug 11 2012 - 05:13:54 EST
Hi Sebastian
> -static void __init clk_init(void)
> +static void __init dove_clk_init(void)
> {
> tclk = clk_register_fixed_rate(NULL, "tclk", NULL, CLK_IS_ROOT,
> - get_tclk());
> + dove_tclk);
>
> orion_clkdev_init(tclk);
> +
> + /* Ensure tclk is always clocked */
> + clk_prepare_enable(tclk);
> }
"ticking" would be better than clocked.
Since this is a root fixed clock, is it necessary to prepare_enable()
it? I think prepare and enable become NOPs in this situation.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/