[PATCH] net: Checking usb_register() return value

From: Marina Makienko
Date: Tue Aug 14 2012 - 04:15:41 EST


ath6kl_usb_init() does not check usb_register() return value.
As a result it may incorrectly report success of driver initialization.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Marina Makienko <makienko@xxxxxxxxx>
---
drivers/net/wireless/ath/ath6kl/usb.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
index 3740c3d..39f05da 100644
--- a/drivers/net/wireless/ath/ath6kl/usb.c
+++ b/drivers/net/wireless/ath/ath6kl/usb.c
@@ -1196,7 +1196,11 @@ static struct usb_driver ath6kl_usb_driver = {

static int ath6kl_usb_init(void)
{
- usb_register(&ath6kl_usb_driver);
+ int ret = usb_register(&ath6kl_usb_driver);
+ if (ret) {
+ ath6kl_err("usb_register() failed: %d\n", ret);
+ return ret;
+ }
return 0;
}

--
1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/