Re: [PATCH V6 4/5] USB: Add EHCI bus glue for Loongson1x SoCs (UPDATED)

[Florian Fainelli]

Hello Kelvin,

On Wednesday 18 January 2012 14:41:16 Kelvin Cheung wrote:
> Use ehci_setup() in ehci_ls1x_reset().
> 
> The Loongson1x SoCs have a built-in EHCI controller.
> This patch adds the necessary glue code to make the generic EHCI
> driver usable for them.
> 
> Signed-off-by: Kelvin Cheung <keguang.zhang@xxxxxxxxx>
> ---

I do not see this driver doing anything fancy which would require an entirely 
new ehci implementation so consider using the generic ehci platform driver 
(drivers/usb/host/ehci-platforms.c) instead.

>  drivers/usb/Kconfig          |    1 +
>  drivers/usb/host/ehci-hcd.c  |    5 ++
>  drivers/usb/host/ehci-ls1x.c |  159 
++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 165 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/host/ehci-ls1x.c
> 
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 85d5a01..78ac78b 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -68,6 +68,7 @@ config USB_ARCH_HAS_EHCI
>  	default y if ARCH_MSM
>  	default y if MICROBLAZE
>  	default y if SPARC_LEON
> +	default y if MACH_LOONGSON1

Do this in arch/mips/Kconfig instead.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/