Re: yama_ptrace_access_check(): possible recursive locking detected
From: Alan Cox
Date: Wed Aug 15 2012 - 14:39:55 EST
> It sounds like get_task_comm shouldn't have locking at all then? It
> should just do a length-limited copy and make sure there is a trailing
> 0-byte?
It has locking so that it has a consistent state and more importantly it
has an accessor function
Directly accessing it is asking for bugs in future. If you hold the
needed lock then just add an
__get_task_comm()
method that asserts the lock is held. That way the rest of the behaviour
remains properly encapsulated for when someone changes it.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/