Re: [PATCH] usb: hcd: use *resource_size_t* for specifying resourcedata

From: Felipe Balbi
Date: Thu Aug 16 2012 - 08:59:55 EST


Hi,

On Thu, Aug 16, 2012 at 06:24:19PM +0530, Kishon Vijay Abraham I wrote:
> Changed the type of rsrc_start and rsrc_len from u64 to resource_size_t
> so that it behaves well with resource API's like *resource_size()* on both
> 32bit and 64bit devices.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>

looks correct to me. FWIW:

Acked-by: Felipe Balbi <balbi@xxxxxx>

> ---
> include/linux/usb/hcd.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index c5fdb14..608050b 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -135,8 +135,8 @@ struct usb_hcd {
>
> unsigned int irq; /* irq allocated */
> void __iomem *regs; /* device memory/io */
> - u64 rsrc_start; /* memory/io resource start */
> - u64 rsrc_len; /* memory/io resource length */
> + resource_size_t rsrc_start; /* memory/io resource start */
> + resource_size_t rsrc_len; /* memory/io resource length */
> unsigned power_budget; /* in mA, 0 = no limit */
>
> /* bandwidth_mutex should be taken before adding or removing
> --
> 1.7.9.5
>

--
balbi

Attachment: signature.asc
Description: Digital signature