Re: [PATCH 2/8] exofs: remove lock/unlock super

[Marco Stornelli]

Il 16/08/2012 14:32, Boaz Harrosh ha scritto:
> On 08/16/2012 03:20 PM, Artem Bityutskiy wrote:
>
> > On Thu, 2012-08-16 at 12:00 +0200, Marco Stornelli wrote:
> > > From: Marco Stornelli <marco.stornelli@xxxxxxxxx>
> > >
> > > Remove lock and unlock super operation.
> > >
> > > Signed-off-by: Marco Stornelli <marco.stornelli@xxxxxxxxx>
> >
> > Acked-by: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
>
>
> Are you sure? It used to be that exofs_sync_fs() could be called
> concurrently.
>
> What about two "bash -c sync" calls or a sync and an unmount
> in parallel. anything protecting that?
>
> If so then sure, but please let me test first.
> Boaz
>
> .

Yes Boaz, I agree, it's the reason I asked for a comments for exofs and 
hpfs. The only reason to have a lock here is to serialize operations in 
parallel on the same super block.

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/