Re: linux-next: build failure after merge of the tip tree

[Stephen Rothwell]

Hi Paul,

On Thu, 16 Aug 2012 12:46:51 -0700 "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Aug 16, 2012 at 01:12:36PM +1000, Stephen Rothwell wrote:
> > 
> > After merging the tip tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > drivers/infiniband/hw/ehca/ehca_irq.c: In function 'find_next_online_cpu':
> > drivers/infiniband/hw/ehca/ehca_irq.c:672:2: error: expected ';' before 'spin_unlock_irqrestore'
> > 
> > Caused by commit 81942621bd6b ("infiniband: Ehca: Use hotplug thread
> > infrastructure").
> > 
> > I have used the tip tree from next-20120814 for today.
> 
> My first reaction was "we tested that!!!", but I see the conversion
> from while(1) to do-while.  Does the following cure it?

Yes, that fixes the build problem.

However, the same commit is also responsible for all these new warnings:

drivers/infiniband/hw/ehca/ehca_irq.c: In function 'queue_comp_task':
drivers/infiniband/hw/ehca/ehca_irq.c:710:9: warning: assignment from incompatible pointer type
drivers/infiniband/hw/ehca/ehca_irq.c:719:10: warning: assignment from incompatible pointer type
drivers/infiniband/hw/ehca/ehca_irq.c: In function 'comp_task_park':
drivers/infiniband/hw/ehca/ehca_irq.c:764:9: warning: assignment from incompatible pointer type
drivers/infiniband/hw/ehca/ehca_irq.c: In function 'comp_task':
drivers/infiniband/hw/ehca/ehca_irq.c:803:1: warning: no return statement in function returning non-void
drivers/infiniband/hw/ehca/ehca_irq.c: At top level:
drivers/infiniband/hw/ehca/ehca_irq.c:807:2: warning: initialization from incompatible pointer type

Please address these.
-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature