Re: [v2.6.34-stable 137/165] USB: Fix Corruption issue in USB ftdidriver ftdi_sio.c

From: Paul Gortmaker
Date: Fri Aug 17 2012 - 11:12:24 EST


On 12-08-17 10:36 AM, Herton Ronaldo Krzesinski wrote:
>> commit b1ffb4c851f185e9051ba837c16d9b84ef688d26 upstream.
>> >
>> > Fix for ftdi_set_termios() glitching output
>> >
>> > ftdi_set_termios() is constantly setting the baud rate, data bits and parity
>> > unnecessarily on every call, . When called while characters are being
>> > transmitted can cause the FTDI chip to corrupt the serial port bit stream
>> > output by stalling the output half a bit during the output of a character.
>> > Simple fix by skipping this setting if the baud rate/data bits/parity are
>> > unchanged.
>> >
>> > Signed-off-by: Andrew Worsley <amworsley@xxxxxxxxx>
> [...]
>
> commit 108e02b12921078a59dcacd048079ece48a4a983 ("USB: ftdi_sio: fix
> initial baud rate") says it addresses a regression on this change,
> something to consider for inclusion with this update.

Thanks Herton, I've queued this and pushed it to 34-longterm-queue.

Paul.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/