RE: [PATCH] leds-lm3530: replace pwm platform functions withgeneric pwm functions

[Kim, Milo]

> > * Rather than having to do the #ifdef here, I think it would be
> better if
> >   the PWM subsystem provided stub functions for pwm_request,
> pwm_config,
> >   pwm_enable, pwm_disable and pwm_free that do nothing, so you can in
> effect
> >   let the compiler optimize away the above code.
> 
> That's actually on my TODO list, but I think it needs to wait until we
> have gotten rid of all legacy implementations. The stubs would have to
> move into the !CONFIG_PWM branch, which will in turn break because the
> legacy implementations would provide non-inlined duplicates.
> 
> Thierry

OK, then it's better to wait fixing that first.

Bryan,
please just ignore this patch.
I'll resend the patch later.

Thank you.

Best Regards,
Milo



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/