Re: [PATCH] sched: add missing call for calc_load_exit_idle

From: Charles Wang
Date: Mon Aug 20 2012 - 04:13:36 EST


No email address provided by Azat Khuzhin, so I don't know
how to let him know this. - -!

On 08/20/2012 04:02 PM, Charles Wang wrote:
From Charles Wang <muming.wq@xxxxxxxxxx>

Azat Khuzhin reported "high loadavg in linux-3.6"

After checking for upstream's code, I found Peter's patch
(Commit id:5167e8d5417bf5c322a703d2927daec727ea40dd) not be
fully applied, missing the call for calc_load_exit_idle.
After that idle exit in sampling window will always be calculated
to non-idle, and the load will be higher than normal.

This patch add the missing call for calc_load_exit_idle.

Signed-off-by: Charles Wang <muming.wq@xxxxxxxxxx>

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 024540f..3a9e5d5 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -573,6 +573,7 @@ static void tick_nohz_restart_sched_tick(struct tick_sched *ts, ktime_t now)
tick_do_update_jiffies64(now);
update_cpu_load_nohz();

+ calc_load_exit_idle();
touch_softlockup_watchdog();
/*
* Cancel the scheduled timer and restore the tick


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/