RE: [RFC][PATCH v2 1/3] efivars: Disable external interrupt whileholding efivars->lock

From: Seiji Aguchi
Date: Mon Aug 20 2012 - 18:08:45 EST




> -----Original Message-----
> From: Mike Waychison [mailto:mikew@xxxxxxxxxx]
> Sent: Monday, August 20, 2012 3:17 PM
> To: Seiji Aguchi
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Luck, Tony (tony.luck@xxxxxxxxx); Matthew Garrett (mjg@xxxxxxxxxx); dzickus@xxxxxxxxxx; dle-
> develop@xxxxxxxxxxxxxxxxxxxxx; Satoru Moriya
> Subject: Re: [RFC][PATCH v2 1/3] efivars: Disable external interrupt while holding efivars->lock
>
> Acked-by: Mike Waychison <mikew@xxxxxxxxxx>
>
> > @@ -1101,11 +1107,12 @@ out_free:
> > void unregister_efivars(struct efivars *efivars) {
> > struct efivar_entry *entry, *n;
> > + unsigned long flags;
> >
> > list_for_each_entry_safe(entry, n, &efivars->list, list) {
> > - spin_lock(&efivars->lock);
> > + spin_lock_irqsave(&efivars->lock, flags);
> > list_del(&entry->list);
> > - spin_unlock(&efivars->lock);
> > + spin_unlock_irqrestore(&efivars->lock, flags);
> > efivar_unregister(entry);
> > }
> > if (efivars->new_var)
>
> Feel free to remove any other uses of flags where you know that you
> are being called from process context.

OK. I will remove the flags from unregister_efivars(), efivar_store_raw(), efivar_create() and efivar_delete().

If I'm missing something, please let me know.

Seiji


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/