Re: [PATCH] perf: create a helper structure perf_event_context

From: Ingo Molnar
Date: Tue Aug 21 2012 - 06:00:11 EST



* Andrew Vagin <avagin@xxxxxxxxxx> wrote:

> 18 files changed, 222 insertions(+), 255 deletions(-)

> -static int process_sample_event(struct perf_tool *tool,
> - union perf_event *event,
> - struct perf_sample *sample,
> - struct perf_evsel *evsel,
> - struct machine *machine)
> +static int process_sample_event(struct perf_event_context *ectx)
> {
> - struct perf_annotate *ann = container_of(tool, struct perf_annotate, tool);
> + struct perf_sample *sample = ectx->sample;
> + struct perf_annotate *ann = container_of(ectx->tool, struct perf_annotate, tool);
> struct addr_location al;

that looks like a nice cleanliness win.

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/