[PATCH v3 0/2] XEN/X86: Document pagetable_reserve PVOPS and enforce a better semantic

From: Attilio Rao
Date: Tue Aug 21 2012 - 11:16:18 EST


When looking for documenting the pagetable_reserve PVOPS, I realized that it
assumes start == pgt_buf_start. I think this is not semantically right
(even if with the current code this should not be a problem in practice) and
what we really want is to extend the logic in order to do the RO -> RW
convertion also for the range [pgt_buf_start, start).
This patch then implements this missing conversion, adding some smaller
cleanups and finally provides documentation for the PVOPS.
Please look at 2/2 for more details on how the comment is structured.
If we get this right we will have a reference to be used later on for others
PVOPS.

The difference with v1 is that sh_start local variable in
xen_mapping_pagetable_reserve() is renamed as begin. Also, the commit messages
have been tweaked.

The difference with v2 is that compiling warnings for x86_32 are fixed
about the usage of wrong format strings for panic() and pr_debug(). Also,
the range printing format has been unified and PFN_PHYS() members are
casted to u64 on printing, to remain consistent (which is basically
what also lib/swiotlb.c does.

Attilio Rao (2):
XEN/X86: Improve semantic support for pagetable_reserve PVOPS
XEN: Document the semantic of the pagetable_reserve PVOPS

arch/x86/include/asm/x86_init.h | 19 +++++++++++++++++--
arch/x86/mm/init.c | 4 ++++
arch/x86/xen/mmu.c | 22 ++++++++++++++++++++--
3 files changed, 41 insertions(+), 4 deletions(-)

--
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/