RE: [RFC][PATCH v3 2/3] efi_pstore: Introducing workqueue updatingsysfs entries

[Seiji Aguchi]

> >  efivars_exit(void)
> >  {
> >         if (efi_enabled) {
> > +               cancel_work_sync(&efivar_work);
> 
> Please move this cancel_work_sync() to be before the efi_enabled test.
>  efi_enabled here means that we registered __efivars.  There may be another driver (gsmi) using the efivars code, so we should
> always be cancelling this work.
> 

OK. I will fix it.
I confirmed that gsmi accually called register_efivars().
Thank you for letting me know about this.

Seiji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/