Re: [PATCH v7 02/12] x86/Kconfig: Add config switch for CPU0 hotplug

[Borislav Petkov]

On Thu, Aug 23, 2012 at 05:56:01PM -0700, Fenghua Yu wrote:
> From: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> 
> New config switch CONFIG_BOOTPARAM_HOTPLUG_CPU0 sets default state of whether
> the CPU0 hotplug is on or off.
> 
> If the switch is off, CPU0 is not hotpluggable by default. But the CPU0 hotplug
> feature can still be turned on by kernel parameter cpu0_hotplug at boot.
> 
> If the switch is on, CPU0 is always hotpluggable. The default value of
> the switch is off.
> 
> Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> ---
>  arch/x86/Kconfig |   29 +++++++++++++++++++++++++++++
>  1 files changed, 29 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 1d91dac..31c8b89 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1711,6 +1711,35 @@ config HOTPLUG_CPU
>  	    automatically on SMP systems. )
>  	  Say N if you want to disable CPU hotplug.
>  
> +config BOOTPARAM_HOTPLUG_CPU0
> +	bool "Set default setting of cpu0_hotpluggable"

Why not change this boot option into something more understandable like

	bool "BSP hotpluggable by default"

or similar?

And, btw, maybe I didn't catch this earlier, but why is in all
user-visible options the thing called "cpu0_*"? Wouldn't it be better to
call it "bsp_*"?

Thanks.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/