Re: [REVIEW][PATCH 09/15] userns: Convert process event connectorto handle kuids and kgids

From: Evgeniy Polyakov
Date: Sun Aug 26 2012 - 08:34:31 EST


On Sat, Aug 25, 2012 at 05:02:59PM -0700, Eric W. Biederman (ebiederm@xxxxxxxxxxxx) wrote:
>
> - Only allow asking for events from the initial user and pid namespace,
> where we generate the events in.
>
> - Convert kuids and kgids into the initial user namespace to report
> them via the process event connector.


Looks good, if IDs are really supposed to be sent only from root
namespace. And you dropped PROC_EVENTS from init/Kconfig, but since it
was no, it should be ok by default.

Feel free to add my acked-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>
Although I thoughs it could be more interesting to generate events
including namespace id

--
Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/