Re: [PATCH 4/6] drivers/usb/host/ohci-nxp.c: adjust inconsistentIS_ERR and PTR_ERR

From: Alan Stern
Date: Mon Aug 27 2012 - 10:38:53 EST


On Sat, 25 Aug 2012, Julia Lawall wrote:

> From: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> Change the call to PTR_ERR to access the value just tested by IS_ERR.

> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> ---
> drivers/usb/host/ohci-nxp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index a446386..c60066a 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -355,7 +355,7 @@ static int __devinit usb_hcd_nxp_probe(struct platform_device *pdev)
> usb_otg_clk = clk_get(&pdev->dev, "ck_usb_otg");
> if (IS_ERR(usb_otg_clk)) {
> dev_err(&pdev->dev, "failed to acquire USB DEV Clock\n");
> - ret = PTR_ERR(usb_dev_clk);
> + ret = PTR_ERR(usb_otg_clk);
> goto out6;
> }

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/