Re: [PATCH 2/2] oprofile: Remove 'WQ on CPUx, prefer CPUy' warning

[Andi Kleen]

On Fri, Aug 24, 2012 at 08:53:31PM +0200, Robert Richter wrote:
> Under certain workloads we see the following warnings:
> 
>  WQ on CPU0, prefer CPU1
>  WQ on CPU0, prefer CPU2
>  WQ on CPU0, prefer CPU3
> 
> It warns the user that the wq to access a per-cpu buffers runs not on
> the same cpu. This happens if the wq is rescheduled on a different cpu
> than where the buffer is located. This was probably implemented to
> detect performance issues. Not sure if there actually is one as the
> buffers are copied to a single buffer anyway which should be the
> actual bottleneck.
> 
> We wont change WQ implementation. Since a user can do nothing the
> warning is pointless. Removing it.

Looks good to me.

Acked-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/