Re: [PATCH v2 4/7] regulator: anatop-regulator: convert to usesyscon to access anatop register

[Dong Aisheng]

On Tue, Aug 28, 2012 at 06:15:35AM +0800, Shawn Guo wrote:
....
> > +	sreg->anatop = syscon_regmap_lookup_by_phandle(np, "fsl,anatop");
> > +	if (IS_ERR(sreg->anatop))
> > +		return PTR_ERR(sreg->anatop);
> > +
> 
> All the anatop regulators are child nodes of anatop.  It looks a little
> odd to use phandle there.  of_get_parent should just works.
> 
Yes, this is a special case.
It's also ok for me to use of_get_parent if you want.
Will update it.

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/