Re: [PATCH v6 04/13] pktcdvd: Switch to bio_kmalloc()

[Peter Osterlund]

On Tue, 28 Aug 2012, Jiri Kosina wrote:

> On Wed, 22 Aug 2012, Tejun Heo wrote:
>
> > (cc'ing Jiri, hi!)
>
> Hi there! :)
>
> > On Wed, Aug 22, 2012 at 10:04:01AM -0700, Kent Overstreet wrote:
> > > This is prep work for killing bi_destructor - previously, pktcdvd had
> > > its own pkt_bio_alloc which was basically duplication bio_kmalloc(),
> > > necessitating its own bi_destructor implementation.
> > >
> > > v5: Un-reorder some functions, to make the patch easier to review
> > >
> > > Signed-off-by: Kent Overstreet <koverstreet@xxxxxxxxxx>
> > > CC: Peter Osterlund <petero2@xxxxxxxxx>
> >
> > Apart from bio_reset() not resetting bi_end_io and bi_private, this
> > looks fine to me but lack of testing makes me a bit hesitant to ack
> > it.
> >
> > Peter doesn't want to be the maintainer of pktcdvd anymore.  Maybe
> > Jiri can be tricked into taking this one too?  :)
>
> Gah, seems like the floppy saga is going to cause me some more trouble in
> the future ... :)
>
> Well, I definitely have hardware back at home that supports this, so I can
> take it. Doesn't seem to be heavy traffic code either.
>
> Peter, ok with that? Also, how was this usually fed upstream -- through
> Jens' tree?

Yes, I am ok with that.

--
Peter Osterlund - peterosterlund2@xxxxxxxxx, petero2@xxxxxxxxx
http://web.comhem.se/petero2home
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/